Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add include_size_comparison option #82

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: add include_size_comparison option #82

merged 2 commits into from
Aug 14, 2024

Conversation

exoego
Copy link
Owner

@exoego exoego commented Aug 14, 2024 •
edited
Loading

Closes #76
Revisits #75 (not released yet), #58

This PR adds a new CSV input include_size_comparison.
It supersedes

  • show_no_change
  • show_total_changes

In other words, one can exclude bundles by its remark (added, deleted, increased, decreased, no-change).
And include a special row total.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

📦 esbuild Bundle Analysis for esbuild-bundle-analyzer

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
tmp/meta.json dist/index.mjs 131.54 KB ⚠️ +3.25 KB (+2.5%)
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: tmp/meta.json, Out file: dist/index.mjs

Path Size
node_modules/minimatch/dist ${{\color{Goldenrod}{ █████ }}}$ 20.4%, 18.21 KB
node_modules/path-scurry/dist ${{\color{Goldenrod}{ ████▊ }}}$ 19.3%, 17.23 KB
node_modules/lru-cache/dist ${{\color{Goldenrod}{ ████▋ }}}$ 18.6%, 16.61 KB
node_modules/glob/dist ${{\color{Goldenrod}{ ████▌ }}}$ 18.1%, 16.23 KB
node_modules/minipass/dist ${{\color{Goldenrod}{ ██▋ }}}$ 10.9%, 9.79 KB
src/compare.ts ${{\color{Goldenrod}{ █▋ }}}$ 6.8%, 6.05 KB
node_modules/brace-expansion/index.js ${{\color{Goldenrod}{ ▌ }}}$ 2.4%, 2.11 KB
src/index.ts ${{\color{Goldenrod}{ ▎ }}}$ 1.4%, 1.26 KB
src/report.ts ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 994 B
node_modules/balanced-match/index.js ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 618 B
src/utils.ts ${{\color{Goldenrod}{ }}}$ 0.4%, 354 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@exoego exoego added the enhancement New feature or request label Aug 14, 2024
@exoego exoego changed the title feat: feat: add include_size_comparison option Aug 14, 2024
@exoego exoego marked this pull request as ready for review August 14, 2024 12:41
@exoego exoego merged commit aedfbb8 into main Aug 14, 2024
4 checks passed
@exoego exoego deleted the filter branch August 14, 2024 12:41
@exoego exoego mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature-request: Collapsable stats
1 participant
@exoego